Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Systray launcher #761

Merged
merged 117 commits into from
Sep 9, 2021
Merged

Systray launcher #761

merged 117 commits into from
Sep 9, 2021

Conversation

alexadhy
Copy link
Contributor

@alexadhy alexadhy commented May 8, 2021 •
edited

Did you run make format && make check? Yes

Part of #543

Changes:

  • Making cross-building on goreleaser works (via golang-cross)
  • Build darwin binaries on darwin host only

How to test this PR:

https://github.com/skycoin/skywire/blob/284937e4a966b49e7b268e2733b02f7aca67779c/docs/systray-builds.md

Running on linux:

Screen Shot 2021-07-06 at 16 13 58

Tested on ubuntu 20.04, gnome DE.

Running on Mac:

Screen Shot 2021-07-06 at 16 16 22

@Darkren
Modify gen-config command to generate app configs optionally
8b28da9 
Following flags were added:

- --has-vpn-client includes VPN client config;
- --has-vpn-server includes VPN server config;
- --has-skychat includes Skychat config;
- --has-skysocks includes Skysocks config;
- --has-skysocks-client includes Skysocks client configю

If no flags are specified, all the configs get generated by default as usual.

Flag `--no-apps` was added. In case one needs to generate config with no apps at all, this flag needs to be specified.
@Darkren
Add debug log
5adabdc
@Darkren
Revert debug log
0fa39d0
@Darkren
Add debug logs
288ce20
@Darkren
Change debug logs
00f9919
@Darkren
Change debug logs
cacec13
@Darkren
Change debug log
ba35916
@Darkren
Change debug logs
998b5f8
@Darkren
Change debug logs
919bb7d
@Darkren
Change debug logs
fc19daa
@Darkren
Add draft systray app which opens hypervisor
47fd0e9
@Darkren
Implement systray app for Linux and OSX
fb84b01
@Darkren
Add draft uninstall function
47ce909
@Darkren
Add separate deinstaller cmd
a9daf07
@Darkren
Setuid only for needed script lines
b590f40
@Darkren
Change deinstallation routine
3b17069
@Darkren
Merge systray app and visor binaries, remove deinstaller cmd
3e1b385
@Darkren
Add debug logs
3217293
@Darkren
More debug logs
8a4027f
@Darkren
Change sys tray icon path
1f1ec65
@Darkren
Make hypervisor have enable_tls false by default for -p flag in c…
c16c158 
…onfig gen
@Darkren
Make hypervisor button enabled in the background
73e1524
@Darkren
Make dmsg.ErrEntityClosed being handled properly
4b3ba5e
@Darkren
Change deinstaller path
c785f6c
@Darkren
Fix deinstaller location
7abc15c
@Darkren
Make systray app quit on os signal
90cf5f1
@Darkren
Add debug logs
f447a6d
@Darkren
Fix shutdown sequence
517f6cc
@Darkren
Add debug logs
86f8430
@Darkren
Add debug log
9b64765
@jdknives jdknives changed the title #651 continuation (Systray) Systray launcher Aug 21, 2021
jdknives
jdknives reviewed Aug 22, 2021
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Just a few small comments and questions from my side.

.goreleaser.yml Outdated Show resolved Hide resolved
.goreleaser.yml Show resolved Hide resolved
.goreleaser-systray.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
internal/gui/gui_darwin.go Show resolved Hide resolved
pkg/util/stdio/arm_dup.go Show resolved Hide resolved
pkg/util/stdio/arm_nondarwin.go Show resolved Hide resolved
pkg/visor/init_cli.go Outdated Show resolved Hide resolved
pkg/visor/visorconfig/config.go Outdated Show resolved Hide resolved
mrpalide
mrpalide reviewed Aug 23, 2021
View reviewed changes
Copy link
Contributor

@mrpalide mrpalide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as my old mistake, seems adding new line at end of codes is off on your IDE.
And just some little comments.

Makefile Outdated Show resolved Hide resolved
internal/gui/gui.go Show resolved Hide resolved
internal/gui/gui.go Show resolved Hide resolved
internal/gui/gui.go Show resolved Hide resolved
internal/gui/gui.go Show resolved Hide resolved
pkg/util/stdio/arm_nondarwin.go Show resolved Hide resolved
cmd/skywire-cli/commands/visor/init_windows.go Outdated Show resolved Hide resolved
pkg/visor/init_windows.go Outdated Show resolved Hide resolved
@mrpalide
Copy link
Contributor

mrpalide commented Aug 23, 2021 •
edited

I want to open browser from systray, but I get following error.

[2021-08-23T22:35:42+04:30] INFO []: Opening hypervisor at http://localhost:8000
[2021-08-23T22:35:42+04:30] ERROR []: Failed to open hypervisor error="failed to open link: webbrowser: can't open browser"

I'm on KDE desktop with Firefox default browser.

Other thing that I see is a sudden interruption without completing the shutdown process.

@alexadhy
Copy link
Contributor Author

alexadhy commented Aug 24, 2021 •
edited

I want to open browser from systray, but I get following error.

[2021-08-23T22:35:42+04:30] INFO []: Opening hypervisor at http://localhost:8000
[2021-08-23T22:35:42+04:30] ERROR []: Failed to open hypervisor error="failed to open link: webbrowser: can't open browser"

I'm on KDE desktop with Firefox default browser.

Other thing that I see is a sudden interruption without completing the shutdown process.

Have you set default browser in xdg-settings?

I'll fix shutdown process today.

@mrpalide
Copy link
Contributor

mrpalide commented Aug 24, 2021 •
edited

Have you set default browser in xdg-settings?

I'll fix shutdown process today.

  1. I didn't set with xdg-settings in terminal and just use Default Application in System Setting Module. I check it and xdg-settings is firefox too. 
    mohammadreza@workstation:~$ xdg-settings get default-web-browser
firefox.desktop
  2. Great.

@alexadhy
Copy link
Contributor Author

alexadhy commented Aug 24, 2021 •
edited

Screen.Recording.2021-08-25.at.00.20.53.mov

Have you set default browser in xdg-settings?
I'll fix shutdown process today.

1. I didn't set with `xdg-settings` in terminal and just use Default Application in System Setting Module. I check it and xdg-settings is firefox too.
   ```
   mohammadreza@workstation:~$ xdg-settings get default-web-browser
   firefox.desktop
   ```

2. Great.

will test on KDE, and see whether it works. Works on KDE Plasma latest, on ubuntu 20.04 see attached video

@jdknives jdknives merged commit e93810e into skycoin:develop Sep 9, 2021
@alexadhy alexadhy deleted the feature/systray branch November 23, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives left review comments

@ersonp ersonp ersonp left review comments

@i-hate-nicknames i-hate-nicknames i-hate-nicknames left review comments

@mrpalide mrpalide mrpalide left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alexadhy @jdknives @mrpalide @ersonp @i-hate-nicknames @Darkren