Feature/docker refactorings #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…xadhy/skywire into feature/docker-refactorings
|
I am still running into the same problem as before. In addition, can we add a make target for building the docker image? |
|
@jdknives: I think it was because you built the image with Should I change that behaviour? |
|
@alexadhy works well. We should also copy over |
jdknives
reviewed
Jun 15, 2021
Makefile
Outdated
| @@ -138,6 +138,9 @@ build-deploy: ## Build for deployment Docker images | |||
| ${OPTS} go build ${BUILD_OPTS_DEPLOY} -o /release/apps/skysocks ./cmd/apps/skysocks | |||
| ${OPTS} go build ${BUILD_OPTS_DEPLOY} -o /release/apps/skysocks-client ./cmd/apps/skysocks-client | |||
|
|
|||
| build-docker: ## Build docker image | |||
| ./ci_scripts/docker-push.sh -t develop -b | |||
There was a problem hiding this comment.
Can we use a var here instead of hardcoding the tag? May be more helpful this way.
jdknives
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? yesFixes #793
Changes:
How to test this PR: