Fix stcpr transport establishment issues #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-hate-nicknames
changed the title
i-hate-nicknames
force-pushed
the
fix/stcpr-redial-loop
branch
from
552fb55
to
f731638
Compare
i-hate-nicknames
force-pushed
the
fix/stcpr-redial-loop
branch
from
52ab0ac
to
8d71486
Compare
i-hate-nicknames
force-pushed
the
fix/stcpr-redial-loop
branch
from
56a8a9a
to
e23cce9
Compare
jdknives
reviewed
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #806
Changes:
How to test this PR:
Run two visors v1 and v2. v1 should have public IP, v2 shouldn't. Public Key of v1 should be less than Public Key of v2.
Set up an stcpr transport from v2 to v1 manually, then stop v2. Restart v2, remove transport and establish it again. Transport should be added in UP state.
Stop v2 again. Start it again, transport should automatically switch to UP state on both ends.