Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer exception #847

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Fix nil pointer exception #847

merged 1 commit into from
Jul 28, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Jul 19, 2021

Did you run make format && make check?
yes

Fixes #846

Changes:

  • Added return statement to error on doHandshake

How to test this PR:

  1. Start hypervisor ./skywire-visor skywire-config.json
  2. Go to visor details inside the hypervisor UI and add a sudph transport to another visor.
  3. There should be no panic.

alexadhy
alexadhy approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@alexadhy alexadhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@jdknives jdknives merged commit aa0aa83 into skycoin:develop Jul 28, 2021
@ersonp ersonp deleted the fix/nil-pointer branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexadhy alexadhy alexadhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ersonp @alexadhy @jdknives