Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keep-alive packet propagation between nodes #87

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Add keep-alive packet propagation between nodes #87

merged 1 commit into from
Dec 25, 2019

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Dec 24, 2019

Fixes #81

Changes:

  • Proper keep-alive packets propagation was added. Now when router receives the keep-alive packet, assuming that we talk about the intermediary node, the packet is being forwarded to the next node along the route. This way all the rules have their activity up to date, preventing unwanted expiry

@Darkren Darkren added bug Something isn't working milestone2 labels Dec 24, 2019
nkryuchkov
nkryuchkov approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@Darkren Darkren merged commit 6e30191 into skycoin:milestone2 Dec 25, 2019
@Darkren Darkren deleted the fix/propagate-keep-alive branch December 25, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov approved these changes

@evanlinjin evanlinjin Awaiting requested review from evanlinjin

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darkren @nkryuchkov