Add sky scanner #235
Merged
Add sky scanner #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealssj
commented
Mar 13, 2018
src/scanner/sky_test.go
Outdated
| } | ||
|
|
||
| func (dsc *dummySkyrpcclient) GetBlockVerboseTx(seq uint64) (*visor.ReadableBlock, error) { | ||
| //TODO (therealssj): refactor this to directly read from the database |
There was a problem hiding this comment.
I dont have a good understanding of the skycoin blockchain structure so I just used the existing functions instead of reading the database values directly
|
Needs config setup as well. The scanner should have a configured initial height to scan from |
therealssj
commented
Mar 14, 2018
src/exchange/receiver.go
Outdated
| switch coinType { | ||
| case scanner.CoinTypeBTC: | ||
| return cfg.SkyBtcExchangeRate, nil | ||
| case scanner.CoinTypeETH: | ||
| return cfg.SkyEthExchangeRate, nil | ||
| case scanner.CoinTypeSKY: | ||
| fallthrough |
There was a problem hiding this comment.
we don't know what sky will be exchanged for
therealssj
commented
Mar 14, 2018
src/exchange/receiver.go
Outdated
| @@ -197,7 +197,8 @@ func getRate(cfg config.SkyExchanger, coinType string) (string, error) { | |||
| case scanner.CoinTypeETH: | |||
| return cfg.SkyEthExchangeRate, nil | |||
| case scanner.CoinTypeSKY: | |||
| fallthrough | |||
| //NOTE: add exchange rate accordingly when needed | |||
| return "0", nil | |||
There was a problem hiding this comment.
need to set this to something to pass the tests
therealssj
force-pushed
the
skyscanner
branch
3 times, most recently
from
b38e80f
to
961c7ff
Compare
therealssj
force-pushed
the
skyscanner
branch
9 times, most recently
from
6c4ca34
to
526b968
Compare
gz-c
suggested changes
Mar 24, 2018
| skyrpc := scanner.NewSkyClient(cfg.SkyRPC.Address) | ||
| err := scanStore.AddSupportedCoin(scanner.CoinTypeSKY) | ||
| if err != nil { | ||
| log.WithError(err).Error("scanStore.AddSupportedCoin(scanner.CoinTypeSKY) failed") |
src/exchange/receiver.go
Outdated
| switch coinType { | ||
| case scanner.CoinTypeBTC: | ||
| return cfg.SkyBtcExchangeRate, nil | ||
| case scanner.CoinTypeETH: | ||
| return cfg.SkyEthExchangeRate, nil | ||
| case scanner.CoinTypeSKY: | ||
| //NOTE: add exchange rate accordingly when needed | ||
| return "0", nil |
There was a problem hiding this comment.
Add a cfg.SkySkyExchangeRate, we can fix the name later
src/scanner/sky.go
Outdated
| @@ -0,0 +1,215 @@ | |||
| // Package scanner scans bitcoin blockchain and check all transactions | |||
src/scanner/sky.go
Outdated
| Base CommonScanner | ||
| } | ||
|
|
||
| // SkyClient implements the SKYRpcClient interface |
src/scanner/sky.go
Outdated
|
|
||
| // block seq of last block is the block count | ||
| blockCnt := lastBlock.Blocks[0].Head.BkSeq | ||
| return int64(blockCnt), nil |
There was a problem hiding this comment.
First block has BkSeq=0 so need to add 1
src/scanner/sky.go
Outdated
| // NewSkyClient create a new skyclient instance | ||
| func NewSkyClient(addr string) *SkyClient { | ||
| skyClient := SkyClient{ | ||
| c: &webrpc.Client{Addr: addr}, |
There was a problem hiding this comment.
Use the gui.Client instead, you'll need to update Gopkg.toml to use the v0.22.0 tag in the dependencies
|
Merge conflict |
gz-c
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.