Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount romfs ourselves #31

Merged
merged 2 commits into from
Nov 1, 2020
Merged

Mount romfs ourselves #31

merged 2 commits into from
Nov 1, 2020

Conversation

Genwald
Copy link
Contributor

@Genwald Genwald commented Oct 8, 2020

  • Runs plugins earlier.
  • Avoids a potential crash if the rom is not yet mounted after >10 seconds.
  • Avoids a potential crash if the game doesn't mount rom as "rom" and mounts too early for skyline to hook it.

Tested with smash ultimate.
Potential memory leak if the game mounts as "rom" as well? Wasn't sure if it'd be safe to free the game's buffer.

@jam1garner
Copy link
Member

Does this break games which have different mount names?

@jam1garner jam1garner merged commit 778f544 into skyline-dev:master Nov 1, 2020
@jakibaki
Copy link

jakibaki commented Nov 5, 2020

I think it does just that.

@Genwald
Copy link
Contributor Author

Genwald commented Nov 5, 2020

In the case of a game using a different mount name, romfs will just be mounted as "rom" as well as whatever name the game chooses. I did not test with other games, but did test using a mount name other than rom on smash ultimate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants