Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Suffix appended by makeTempDir has a trailing brace #9

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Fix: Suffix appended by makeTempDir has a trailing brace #9

merged 2 commits into from
Jan 2, 2021

Conversation

williamthorsen
Copy link
Member

  • Fixed an issue where the random suffix appended by makeTempDir always had a trailing brace
  • Added a new check of type narrowing to includeIf

@williamthorsen williamthorsen added the bug Something isn't working label Jan 2, 2021
@camthorsen camthorsen changed the title Fix: Suffix appending by makeTempDir has a trailing brace Fix: Suffix appended by makeTempDir has a trailing brace Jan 2, 2021
camthorsen
camthorsen approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@camthorsen camthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@camthorsen camthorsen merged commit 6ab659f into next Jan 2, 2021
@camthorsen camthorsen deleted the random-suffix-fix branch January 2, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camthorsen camthorsen camthorsen approved these changes

Assignees

@camthorsen camthorsen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamthorsen @camthorsen