Use a single resource group for all Azure resources #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkumar
force-pushed
the
feature-azure-resource-group
branch
from
4147487
to
6fbbd22
Compare
|
Before merging this, we should make sure that this is actually faster/more reliable than the previous design, which had a resource group for each VM. I'll need to do some testing to be sure of this. |
samkumar
force-pushed
the
feature-azure-resource-group
branch
2 times, most recently
from
aa719f3
to
72c423b
Compare
|
I just added code to look for orphaned Azure resources and clean them up. Aside from perhaps additional testing, I think that this is ready. |
samkumar
force-pushed
the
feature-azure-resource-group
branch
from
72c423b
to
9038d66
Compare
This was referenced Feb 21, 2022
Closed
|
This seems to take slightly longer to provision. Is this expected? Rest of it looks good to me! |
ShishirPatil
approved these changes
Feb 22, 2022
|
@ShishirPatil The biggest thing is that I hoped it would be more reliable now, since we aren't creating/destroying resource groups all the time anymore. You were running into the reliability issues earlier, so you're in the best position to tell whether this resolves those issues... Merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #125
This pull request modifies Skylark's Azure support to use a single
skylarkresource group for all resources spawned for a transfer, across all Azure regions. Previously, Skylark would create a separate resource group for each VM and its associated resources (disk, NIC, public IP address, etc.). The motivation behind this change is to make Azure operations faster and more reliable, since we found that performing operations on resource groups can be quite slow.