Minor fixes for S3 PR to resolve AWS bug #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahwooders
added a commit
that referenced
this pull request
Jan 20, 2022
* got paras' commented s3 file creation code to (mostly) run * comments for adding s3 integration * add object store info to ChunkRequestHop * add object store info to ChunkRequestHop * fix formatting * add s3 download function * remove af-south-1 * merge * send aws credentials with docker envs * s3 upload * remove * merge * cleanup * add missing requirements for gateway * cleanup/format * more cleanup * Fixing some minor typos * cache object store interface * remove af-south-1 * Revert "Fixing some minor typos" This reverts commit 2e684b3. * comment out region to stop vpc error * add part size / throughput args * Minor fixes for S3 PR to resolve AWS bug (#79) * Reuse S3Interface, batch S3 delete calls to fix AWS bug * When getting object sizes, throttle requests to avoid retry errors * Types in Chunk should be Optional Co-authored-by: Sarah Wooders <sarahwooders@gmail.com> * add back regions * uncomment regions Co-authored-by: Ubuntu <ubuntu@ip-172-31-52-37.us-west-2.compute.internal> Co-authored-by: Paras Jain <parasj96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR will merge back into the s3-integration branch, not main.