Feature: SCP (Samsung Cloud Platform) Support Contribution

[sangjun-kang]

Overview

This pull request adds support for SCP (Samsung Cloud Platform) by implementing the necessary code. I have completed the development and testing phases and followed all the procedures outlined in the contributing guide.

Details

• Contributor: sangjun-kang (aau213)
• https://github.com/skypilot-sds/skyplane/tree/scp-contribution
• Branch: scp-contribution

Progress

• Code development and testing completed
• Issue and discussion registration
• Code review and adjustments

[sarahwooders]

@sangjun-kang could you please fix the formatting checks? You can run it with:

pip install -r requirements-dev.txt
black -l 140 .
pytype --config .pytype.cfg skyplane
autoflake --in-place --remove-all-unused-imports --remove-unused-variables --recursive skyplane

[sangjun-kang]

@sangjun-kang could you please fix the formatting checks? You can run it with:

pip install -r requirements-dev.txt
black -l 140 .
pytype --config .pytype.cfg skyplane
autoflake --in-place --remove-all-unused-imports --remove-unused-variables --recursive skyplane

Hello @sarahwooders,

It seems that some parts were missed during the execution of the black formatting.
I have re-run the checks, and everything should be in order now.
Please review the changes, and let me know if there are any further adjustments needed.

Thank you!

[sarahwooders]

Thank you! Are there also any additional dependencies needed for SCP? If so, could you please update https://github.com/skyplane-project/skyplane/blob/main/pyproject.toml

[sangjun-kang]

Thank you! Are there also any additional dependencies needed for SCP? If so, could you please update https://github.com/skyplane-project/skyplane/blob/main/pyproject.toml

Thank you for your comment! I've confirmed, and SCP doesn't require any additional dependencies beyond boto3.
I've updated the pyproject.toml to reflect the SCP section.
I appreciate your attention to detail. If you have any more questions or concerns, feel free to let me know!

[sangjun-kang]

Sorry, Sarah. The authentication key shared by Suk-hoon had IP restrictions (for security reasons). Suk-hoon has removed the IP restrictions, so please test it again. Also, there is authentication key information in the logs, so it would be great if you could erase the logs.

[SukHoon-Jung]

nk you for your comment! I've confirmed, and SCP doesn't require any additional dependencies beyond boto3.
I've updated the pyproject.toml to reflect the SCP section.
I appreciate your attention to detail. If you have any more questions or concerns, feel free to let me kno

@sarahwooders, @sangjun-kang , This error is due to the security settings of my account. sorry.
I've changed the settings so you can access now.

By the way, you mentioned that there was an error in the credential format.
could you pinpoint where the error occurs?

[sarahwooders]

I just deleted the comment, and the skyplane init command worked now, thanks!

[sangjun-kang]

@sarahwooders, I encountered errors in the following files when running pytype --config .pytype.cfg skyplane, but these are not files I have committed, so I couldn't address them. Please take a look:

skyplane/gateway/gateway_queue.py
skyplane/gateway/operators/gateway_receiver.py
skyplane/gateway/gateway_daemon_api.py
skyplane/obj_store/hdfs_interface.py
skyplane/obj_store/r2_interface.py
skyplane/cli/cli_cloud.py
skyplane/gateway/operators/gateway_operator.py
skyplane/cli/impl/progress_bar.py
skyplane/planner/planner.py

[sarahwooders]

@sangjun-kang sorry for the delayed response, have been traveling! I can take a look at the pytest issues this week.

[sarahwooders]

Could you run poetry install --with dev and poetry run black -l 140 .? I can also fix the formatting if you give me push permissions on your repo. On my end, it only changed two files.

[sangjun-kang]

Could you run poetry install --with dev and poetry run black -l 140 .? I can also fix the formatting if you give me push permissions on your repo. On my end, it only changed two files.

Hi @sarahwooders

I made changes to the SCP Object Storage API yesterday, adjusting some source code. It seems black formatting was missed, so I ran it again and committed the changes.
And I've granted you repo access. Let me know if you need anything else.

Thanks,

[sarahwooders]

This now works for me - thank you so much for the contribution! I'll merge once the tests re-run.