Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typedoc erroring #7

Merged
merged 2 commits into from
Jul 24, 2020
Merged

chore: fix typedoc erroring #7

merged 2 commits into from
Jul 24, 2020

Conversation

vladfrangu
Copy link
Collaborator

Yes. It works.

No. There is no @types/rollup-plugin-cleaner

kyranet
kyranet previously approved these changes Jul 24, 2020
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the accepted fix, rollup's config file is none of TypeDoc's concern and must not be included.

Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the better fix AFAIK

typedoc.json Show resolved Hide resolved
typedoc.json Outdated Show resolved Hide resolved
Nitpicker smh <3

Co-authored-by: Jeroen Claassens <support@favware.tech>
@favna favna merged commit 85de848 into main Jul 24, 2020
@favna favna deleted the fix/cd-docs branch July 24, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants