Add exception for kubernetes_cluster_role's non_resource_urls rule field #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an exception for the conversion of kubernetes'
nonResourceURLs
ClusterRole & Role rule field into the terraform provider'snon_resource_urls
casing.Without this change, the field is converted as
non_resource_ur_ls
.I believe the underlying issue is that converting plain strings poses an issue with plural acronyms for which case is not explicitly defined:
cf. https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#naming-conventions
I believe the conversion process should take the source casing into account (e.g. from Camel Case to Snake Case), or better yet have some pivot format defining at the very least what's a word, an acronym, and if it's plural or singular. I did not find any Go implementation doing that yet.