Preventing cyclic dependency by inlining Op.iterator #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stigi
changed the title
|
Would love to see this merged. The circular dependency is causing me trouble when built with rollup. |
|
@jhchen Let me know if I can do anything to help with this PR getting stamped 🙌 |
|
This has been merged 8c4d16e - thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57 by inlining
Op.iterator.This PR also extracts the iterator tests into their own file.
One question open question:
Delta.Op.Iteratorwas part of the public API of this module, even though not mentioned in the Readme. It got replaced byDelta.Iterator, but not sure if this is considered a breaking change. I checked the main quill sources wether it's been accessed and also did a GitHub Search, and only one place turned up, so I guess we're pretty safe.Testplan
✅
npm run test✅
npm run lint