Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph dispappears while removing words via Ctrl+Backspace and undo'ing #1028

Closed
antonlabunets opened this issue Oct 6, 2016 · 2 comments

Comments

@antonlabunets
Copy link

Paragraph worth of data disappears after 3 Ctrl + Backspace and 2 Ctrl + Z to undo the word removal.

Steps for Reproduction

  1. Visit http://quilljs.com/playground
  2. Copy the text non-column text blocks from http://lipsum.com/ [START with the header "The standard Lorem Ipsum passage, used since the 1500s" and END at "to avoid worse pains." before the help@limpsum.com block]
  3. Use Ctrl + Backspace to remove 3 words ("Unable to get property 'mutations' of undefined or null reference" shows up in the console at blot.update(blot.domNode[Registry.DATA_KEY].mutations || []);). Then Ctrl + Z to undo 2 times (See "Unable to get property 'length' of undefined or null reference" now in the console on keydown var curContext = { range...)

Expected behavior: Words are re-added back one by one until we get back to full paragraph

Actual behavior: After 2nd redo, the whole paragraph disappears and "Cannot read property 'mutations' of undefined" throws at

Platforms: IE 11.0.9600.18450 windows 10, 8 or 2012 R2

Include browser, operating system and respective versions

Version: We see it on 1.0 final internally and 1.0.6 from playground

Run Quill.version to find out

@anindara
Copy link

anindara commented Oct 6, 2016

This might help: Looks like when trying to update the underlying TextBlot with the mutations in its domNode, we are unable to find the Registry.DATA_KEY in this blot's domNode. Enclosed

image

Referenced Parchment issue has more details

@jhchen
Copy link
Member

jhchen commented Jan 2, 2017

Fixed in Parchment 1.0.8.

@jhchen jhchen closed this as completed Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants