Background color is lost if moved to a non-attributed line due to deletes.

[byronm]

Browser: Chrome 26

Steps to reproduce:

1. Type the text "abc\ndef"
2. Highlight "ef" and apply a background color.
3. Highlight "abc\nd" and hit delete.

Expected Result
"ef" with the previously applied background color.

Actual Result
"ef" with no background color.

[byronm]

I'm still seeing the issue after pulling this code. Are you sure 332ecf0 fixed it?

[jhchen]

Think so... did you rebuild? This should have affected any span formatting so font family/size and it's working on beta.

[byronm]

I did rebuild...

Did you explicitly test background color? Experimenting a bit more I see that font family/size works in my dev environment, but background color does not. We don't have background color hooked up on beta but I'd guess it fails there too.

[jhchen]

Interesting yeah it's actually only affecting background color now for some reason. Color, font family and font size should be fixed now though.

[byronm]

I've had a number of fuzzer runs where an attribute other than background color is lost. I've seen size and font-family get dropped, for example. I don't know how to reproduce making a specific attribute get lost, but I have observed that only one attribute from the collection is dropped.

[byronm]

To reproduce font-family being lost:

1. Type "ab\nc"
2. Apply the following formatting to "c", in the following order: background-color: blue, color: yellow, size: large, italic: true, family: serif
3. Delete "\n"

Expected: "c" having the previously listed formatting.
Actual: "c" has the previously listed formatting, except the Serif font-family is dropped and it defaults to San Serif.

Note that both the order the attributes are applied in and the deletion of the \n before the formatted character are necessary to reproduce the bug.

[jhchen]

No longer reproducible