New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix length mismatch when copying code #3028

Merged

jhchen merged 1 commit into slab:develop from luin:copy-code

Apr 30, 2020

Member

luin commented Apr 28, 2020 •

edited

Loading

CodeBlockContainer#html() generates duplicated \n when deals with empty lines. See the test plan for reproduction steps.

This PR added a fix for that, also fixed a related issue that copying & pasting code block doesn't keep the highlighting language.

Test Plan

Run npm start
Visit http://localhost:9000/standalone/full/
Copy the following code block to the editor:

start





end

Add some plain text after the code block. See the screenshot below.

Copy the code block in the editor and paste after the plain text.
Make sure the pasted code block has the same content as the original one.
Set a highlighting language after step 3 and try again. Make sure the pasted code block keeps the language setting.

luin force-pushed the copy-code branch from 68c4537 to dbea9d2 Compare

April 28, 2020 14:45


          Fix length mismatch when copying code

83e8c11

luin force-pushed the copy-code branch from dbea9d2 to 83e8c11 Compare

April 28, 2020 15:18

jhchen merged commit 125bc3c into slab:develop

luin deleted the copy-code branch

May 5, 2020 04:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet