Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for EscapeMessage function in slack #833

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add test for EscapeMessage function in slack #833

merged 1 commit into from
Oct 27, 2020

Conversation

sryoya
Copy link
Contributor

@sryoya sryoya commented Oct 23, 2020

Description

Just added a new test to EscapeMessage in slackutilsx, which had not been covered by existing tests.

@sryoya sryoya closed this Oct 23, 2020
@sryoya sryoya reopened this Oct 23, 2020
@sryoya sryoya closed this Oct 23, 2020
@sryoya sryoya reopened this Oct 23, 2020
@sryoya
Copy link
Contributor Author

sryoya commented Oct 23, 2020

Sorry, as CI seemed to have failed first by a temporary reason, I closed PR once and reopened to make that rerun.

kanata2
kanata2 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kanata2 kanata2 merged commit 686c209 into slack-go:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sryoya @kanata2