Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inheriting or extending SlackRubyBot::Server #18

Closed
dblock opened this issue Jun 11, 2016 · 1 comment
Closed

Support inheriting or extending SlackRubyBot::Server #18

dblock opened this issue Jun 11, 2016 · 1 comment

Comments

@dblock
Copy link
Collaborator

dblock commented Jun 11, 2016

See https://github.com/dblock/slack-amber-alert/blob/use-slack-ruby-bot-server/slack-amber-alert/server.rb, an attempt to convert the slack-amber-alert gem into using slack-ruby-bot-server.

We instantiate SlackRubyBotServer::Server here, so deriving from it doesn't work.

For now monkey patching this.

@dblock
Copy link
Collaborator Author

dblock commented Jul 3, 2016

This was implemented via dblock@3009404 and dblock@1f64537.

@dblock dblock closed this as completed Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant