-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add admin web api methods #305
Conversation
I changed a few small things in the changelog:
|
This looks good, but there seem to be legit spec failures? I haven't looked any deeper than that. |
Ok, I'll investigate! Why does Ruby 2.4.1 on Travis only run |
I get the same failures locally when I run the specs on master, so I don't think they are related to the changes in this PR. |
Danger is what gives us changelog checking and stuff like that. |
Yes thank you, we want that fixed first. |
@dblock The culprit is Faraday. They are preparing for a v1.0 release and (unintentionally?) introduced some breaking changes from 0.17.0 to 0.17.1. Basically, in 0.17.0, But in 0.17.1, What to do? I added a check for the arity of |
Are they releasing 0.17.2 fixing the regression? Otherwise make our code compatible with 0.17.1 and add a |
I opened an issue in the Faraday repo and will add a limit to |
I updated the API methods via
rake slack:api:update
, which added lots of new admin methods.Once those are merged, we can remove the undocumented
Slack::Web::Api::Endpoints::UsersAdmin.users_admin_invite