fix inheriting from Faraday::Error in Faraday v0.17.1 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#308](https://github.com/slack-ruby/slack-ruby-client/pull/308): Fix inheriting from faraday::error in faraday v0.17.1 - [@manuelmeurer](https://github.com/manuelmeurer).Generated by 🚫 danger |
|
Looks like for backwards compatibility we can assign |
|
You're right, let's do that instead! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faraday changed the signature of an error class, as explained here.
This PR fixes inheriting from that error class and limits the Faraday version to
>= 0.17.1.I opened an issue in the Faraday repo, let's wait for their response. Maybe they are open to reverting the change, then we could simple change the Faraday version requirement to
!= 0.17.1.