No longer exit on client close

[davefp]

Fixes #127

[davefp]

I've been unable to 'really' test this as simulating network problems by simply severing my local wifi connection results in an error on reconnect which also causes the process to exit.

Suggestions on better tools/strategies to test this are welcome! In the meantime I'm going to be running my branch on a production hubot to see if any problems arise.

[austinpray]

@evansolomon can we get a release with this included?

[ddffx]

@evansolomon any plan to put it in a release?

[goofansu]

👍 Need a release

[goofansu]

Hubot says Slack client closed, waiting for reconnect but cannot connect. I've waited for hours.

[goofansu]

It is terminated. I ran it on my Macbook Pro.

[Tue May 19 2015 13:50:12 GMT+0800 (CST)] INFO Connecting...
[Tue May 19 2015 13:50:32 GMT+0800 (CST)] INFO Logged in as yybot of 上海页游网络科技, but not yet connected
[Tue May 19 2015 13:50:38 GMT+0800 (CST)] INFO Slack client now connected
[Tue May 19 2015 13:50:39 GMT+0800 (CST)] INFO Using default redis on localhost:6379
[Tue May 19 2015 13:50:39 GMT+0800 (CST)] INFO Data for hubot brain retrieved from Redis
[Tue May 19 2015 13:52:43 GMT+0800 (CST)] ERROR Last pong is too old: 14.638
[Tue May 19 2015 13:52:43 GMT+0800 (CST)] INFO Reconnecting in 1000ms
[Tue May 19 2015 13:52:44 GMT+0800 (CST)] INFO Attempting reconnect
[Tue May 19 2015 13:52:44 GMT+0800 (CST)] INFO Connecting...
[Tue May 19 2015 13:53:03 GMT+0800 (CST)] INFO Slack client closed, waiting for reconnect
[Tue May 19 2015 13:53:05 GMT+0800 (CST)] INFO Logged in as yybot of 上海页游网络科技, but not yet connected
[Tue May 19 2015 13:53:07 GMT+0800 (CST)] INFO Slack client now connected
[Tue May 19 2015 13:53:07 GMT+0800 (CST)] INFO Using default redis on localhost:6379
[Tue May 19 2015 13:53:07 GMT+0800 (CST)] INFO Data for hubot brain retrieved from Redis
[Tue May 19 2015 14:00:17 GMT+0800 (CST)] ERROR Last pong is too old: 14.705
[Tue May 19 2015 14:00:17 GMT+0800 (CST)] INFO Reconnecting in 1000ms
[Tue May 19 2015 14:00:18 GMT+0800 (CST)] INFO Attempting reconnect
[Tue May 19 2015 14:00:18 GMT+0800 (CST)] INFO Connecting...
[Tue May 19 2015 14:00:47 GMT+0800 (CST)] INFO Slack client closed, waiting for reconnect
[Tue May 19 2015 14:02:44 GMT+0800 (CST)] ERROR Received error "ECONNRESET"
[Tue May 19 2015 14:02:44 GMT+0800 (CST)] ERROR undefined
[Tue May 19 2015 14:02:44 GMT+0800 (CST)] ERROR Exiting in 1 second
[Tue May 19 2015 14:02:44 GMT+0800 (CST)] INFO Reconnecting in 2000ms

[danielktaylor]

Tested this fix and it works, but then the listeners do not reinitialize or something. The bot rejoins the channel but does not respond to any commands.

[technicalpickles]

cc #228 for tracking getting this released

[kimamula]

Hubot says Slack client closed, waiting for reconnect but cannot connect. I've waited for hours.

I ran into the same problem.
It is likely we have to wait until slackapi/node-slack-sdk#5 to be solved.