-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconnect doesn't work very well #5
Comments
Logging in |
I have the same problem. Can i help debug it?
I put a few console.logs into If this turns something up, i'll get back to you. [edit] my log now looks like this:
|
This does not really help. It appears that the reconnect does in fact work, but my bot does not respond anymore:
Interesting is, that the |
Funny detail: The connection works alright: if i send messages, i can see a lot of |
+1, has stumbled upon the same issue.
|
👍 |
I'll try to catch the attention of @grantmd, maybe he has an idea how we can continue to debug this. |
Possibly related to slackapi/hubot-slack#127 ? |
running on a raspberrypi it takes a while to get through the startup routine. Long enough that the 10,000ms time at startup is causing the hubot to die.
updating the line 135 of client.js to:
allows my raspberrypi to startup hubot without any drama and stay running(output captured at debug log level)
|
This is really frustrating if hubot does deploys for qa 😢 |
I also ran into this issue when running hubot on a raspi - increasing the pong timeout allowed enough time for the startup. Would allowing a parameter to override the pong timeout be a suitable interim solution? |
I'm having this same issue. My bot stays connected for hours, sometimes days, then disconnects. It does not seem to be throwing any errors. I'm running on a t1.micro instance on AWS – so I should have a little more power than a raspi. I'm creating a new Slack client with |
@jasford: i'm using it in a hubot installation, where i recently upgraded the intermediary layer (hubot-slack). For me, the problem is now much less of a hassle. Maybe that helps you find a workaround for you, too. |
I'm not using |
Yes, i realize that. I just meant, maybe you can copy their change over to your code. |
I am trying to send messages to all the chat windows from a chat room and slack disconnects with this error message |
having same issue with Most of the time it just goes it reconnects fine, the it seems to me the also maybe the client state needs to be reset after a reconnect? something like;
|
same problem here. i have resorted to restarting the bot frequently. |
same, but that's no fun :P |
Having the same issue. Hope this get's fixed soon. Restarting the bot every other day isn't really a solution. |
when the pong timeout, it call reconnect, but which should not do that if autoConnect is false. |
+1 |
Same issue here:
|
I'd appreciate it if people tested #66 and posted their thoughts. Adopting that branch would require you to abandon any explicit If you want to test this + some websocket upgrades and fixes, I've been using https://github.com/vanm/node-slack-client/tree/ws-and-team-migration-fixes in production. |
Ok, first off, I apologize for how long it's taken us to resolve these issues. I just pushed the 2.0.0 release for this library, which is a ground up refactor with the aim of building a lib that both Slack and our external contributors can easily work with and improve. It also includes substantially improved reconnection logic and handling, for both routine disconnects as well So, I'd suggest that the best way to resolve these issues is to upgrade to the latest version. If you have any problems in doing that, please create a new issue and I'll try and help you in there. |
I have hubot with slack adapter and it fails to reconnect after connection loss.
and then nothing happens.
The text was updated successfully, but these errors were encountered: