Add the ability to parse aggregations with OpenSearch #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlb
requested changes
Sep 26, 2024
astra/src/main/java/com/slack/astra/logstore/search/LogIndexSearcherImpl.java
Outdated
Show resolved
Hide resolved
astra/src/main/java/com/slack/astra/logstore/search/SearchResultAggregatorImpl.java
Outdated
Show resolved
Hide resolved
astra/src/main/java/com/slack/astra/logstore/search/SearchResultAggregatorImpl.java
Outdated
Show resolved
Hide resolved
| if (!searchRequest.getAggregationJson().isEmpty()) { | ||
| SearchModule searchModule = new SearchModule(Settings.EMPTY, List.of()); | ||
| try { | ||
| ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
Object mappers should only be initialized once - consider refactoring this so that these initialization for mappers/parsers only have to be paid one time at class construction.
ermontross
previously approved these changes
Sep 26, 2024
|
Closes #629 |
|
Closes #628 |
This was
linked to
issues
Sep 30, 2024
…com:slackhq/kaldb into ksammons-parse-aggregations-with-opensearch
bryanlb
reviewed
Sep 30, 2024
astra/src/main/java/com/slack/astra/logstore/search/SearchResultUtils.java
Outdated
Show resolved
Hide resolved
bryanlb
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to parse aggregations with OpenSearch when the optional feature flag
astra.query.useOpenSearchAggregationParsingis enabled. This follows the same pattern as the query refactor we did awhile back, keeping both the old parsing and new parsing paths in the code, and only switching between based on the feature flag. As such it should be reasonably inert and safe to deploy.I also did some minor fixes to to the changes made in #1081, and added some tests; both of which were missed due to time constraints.
Requirements