Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample app does not restore state when changing tabs #116

Open
ZacSweers opened this issue Sep 19, 2022 · 0 comments · May be fixed by #1168
Open

Sample app does not restore state when changing tabs #116

ZacSweers opened this issue Sep 19, 2022 · 0 comments · May be fixed by #1168
Labels
bug Something isn't working samples Anything relating to sample projects

Comments

@ZacSweers
Copy link
Collaborator

If you scroll the main pet list feed, go to the about tab, then go back, it starts at the top of the feed again
@ZacSweers ZacSweers added bug Something isn't working samples Anything relating to sample projects labels Sep 19, 2022
@kierse kierse mentioned this issue Nov 29, 2022
Closed
ZacSweers added a commit that referenced this issue Jan 31, 2024
@ZacSweers
WIP persist tab state
a8544ae 
This is just some tinkering to resolve #116 and after talking with @bryanstern. Wanna iterate on this more and see if we can make this simpler, and also possibly explore implementing an analogous `RetainedStateHolder`.

Another thing this highlights is the fact that we always initially show a progress indicator even when restoring from a loaded state, wonder what we can do to improve that.
@ZacSweers ZacSweers linked a pull request Jan 31, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working samples Anything relating to sample projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP RetainedStateHolder slackhq/circuit
1 participant
@ZacSweers