Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay snapshot tests #1121

Closed
wants to merge 23 commits into from
Closed

Overlay snapshot tests #1121

wants to merge 23 commits into from

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Jan 16, 2024

Neither work yet

Refs:

To run:

./gradlew :circuitx:overlays:recordRoborazzi :circuitx:overlays:recordRoborazziJvm --continue

Android tests pass but capture nothing on the screen.

JVM tests fail due to an esoteric error in skiko

java.lang.RuntimeException: Can't wrap nullptr
	at org.jetbrains.skia.impl.Native.<init>(Native.jvm.kt:40)
	at org.jetbrains.skia.impl.Managed.<init>(Managed.jvm.kt:12)
	at org.jetbrains.skia.impl.RefCnt.<init>(RefCnt.jvm.kt:6)
	at org.jetbrains.skia.Image.<init>(Image.kt:6)
	at org.jetbrains.skia.Surface.makeImageSnapshot(Surface.kt:762)
	at androidx.compose.ui.test.SkikoComposeUiTest.captureToImage(ComposeUiTest.skikoMain.kt:343)
	at androidx.compose.ui.test.SkikoComposeUiTest.captureToImage(ComposeUiTest.skikoMain.kt:348)
	at io.github.takahirom.roborazzi.RoborazziDesktopKt.captureRoboImage(RoborazziDesktop.kt:39)
	at io.github.takahirom.roborazzi.RoborazziDesktopKt.captureRoboImage(RoborazziDesktop.kt:23)
	at io.github.takahirom.roborazzi.RoborazziDesktopKt.captureRoboImage$default(RoborazziDesktop.kt:16)
	at com.slack.circuitx.overlays.OverlaySnapshotTests$alertDialog$1.invoke(OverlaySnapshotTests.kt:62)
	at com.slack.circuitx.overlays.OverlaySnapshotTests$alertDialog$1.invoke(OverlaySnapshotTests.kt:34)
	at androidx.compose.ui.test.SkikoComposeUiTest.runTest(ComposeUiTest.skikoMain.kt:170)
	at androidx.compose.ui.test.ComposeUiTest_desktopKt.runDesktopComposeUiTest(ComposeUiTest.desktop.kt:41)
	at androidx.compose.ui.test.ComposeUiTest_desktopKt.runDesktopComposeUiTest$default(ComposeUiTest.desktop.kt:34)
	at com.slack.circuitx.overlays.OverlaySnapshotTests.alertDialog(OverlaySnapshotTests.kt:34)

Base automatically changed from z/overlayImprovements to main January 16, 2024 18:47
@ZacSweers
Copy link
Collaborator Author

Closing for now

@ZacSweers ZacSweers closed this Jul 20, 2024
@ZacSweers ZacSweers deleted the z/overlaySnapshots branch July 20, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant