-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PluginRepositoryAuthProvider for Custom Repository Authentication #500
Conversation
…ginal test file for ChangelogParser
Here's an example of the changes: @Test
fun `one entry, no previous entries with no italics`() {
val input =
"""
Changelog
=========
0.9.17
------
2023-07-07
- Don't register `RakeDependencies` task on platform projects.
- Fix configuration cache for Dependency Rake. Note that DAGP doesn't yet support it.
- Add Dependency Rake usage to its doc.
- Add missing identifiers aggregation for Dependency Rake. This makes it easier to find and add missing identifiers to version catalogs that dependency rake expects.
- `./gradlew aggregateMissingIdentifiers -Pslack.gradle.config.enableAnalysisPlugin=true --no-configuration-cache`
"""
.trimIndent()
val expectedDate = LocalDate.of(2023, 7, 7)
val (changeLogString, latestEntry) = ChangelogParser.readFile(input, null)
assertThat(changeLogString).isEqualTo(input)
assertThat(latestEntry).isEqualTo(expectedDate)
}
Here's an example of the changes: class ChangelogParserNoItalicsTest {
// All test methods removed
} By following these steps, the code will be improved by removing unnecessary code and simplifying the tests. |
@@ -0,0 +1,28 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes need to be made in artifactory-authenticator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay: 3f2536b
Continuing from #500. Also had to remove the okio dependency as it appears to conflict with dependencies coming from the intellij plugin now, so using standard java to do it. Tested this with studio giraffe (the bugged version) and it works now <!-- ⬆ Put your description above this! ⬆ Please be descriptive and detailed. Please read our [Contributing Guidelines](https://github.com/tinyspeck/slack-gradle-plugin/blob/main/.github/CONTRIBUTING.md) and [Code of Conduct](https://slackhq.github.io/code-of-conduct). Don't worry about deleting this, it's not visible in the PR! -->
Done in #509 |
Solution from: https://youtrack.jetbrains.com/issue/IDEA-315487/PluginRepositoryAuthProvider-is-broken-in-2022.3-making-custom-repository-authentication-impossible#focus=Comments-27-6990965.0-0