Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven publish with shadow build #40

Merged
merged 3 commits into from
May 15, 2020
Merged

Fix maven publish with shadow build #40

merged 3 commits into from
May 15, 2020

Conversation

ZacSweers
Copy link
Collaborator

No description provided.

@ZacSweers ZacSweers requested a review from jschear May 15, 2020 07:48
configure<PublishingExtension> {
publications.withType<MavenPublication>().configureEach {
if (name == "pluginMaven") {
// Ugly but artifact() doesn't support TaskProviders

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so annoying

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that it fails at runtime too. Who needs type safety

@ZacSweers ZacSweers merged commit 64f9941 into master May 15, 2020
@ZacSweers ZacSweers deleted the z/updates branch May 15, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants