-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor remotes and handshaking to give every address a fair shot #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrownus
force-pushed
the
e2e-lies
branch
5 times, most recently
from
April 9, 2021 17:49
8e6e5e3
to
e4c7a73
Compare
nbrownus
force-pushed
the
e2e-lies
branch
2 times, most recently
from
April 9, 2021 17:55
90775dd
to
1cbb15d
Compare
nbrownus
force-pushed
the
e2e-lies
branch
2 times, most recently
from
April 13, 2021 04:23
6f0960e
to
e1e2c6d
Compare
wadey
reviewed
Apr 13, 2021
nbrownus
changed the title
WIP: Refactor remotes and handshaking to give every address a fair shot
Refactor remotes and handshaking to give every address a fair shot
Apr 13, 2021
wadey
previously approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my issues have been resolved, this is a big change but I think it looks good (and probably safer than what we have now) 👍
wadey
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change unifies the idea of the lighthouse cache and the hostinfo remotes address list. The motivation is:
Limits are 10 ipv4 and 10 ipv6 per lighthouse (clients) or per client (lighthouse).
Learned addresses changed to only store 1 of each v4 and v6 address. This should benefit hosts that get new public facing ports through a NAT frequently.
This also adds a check to ensure the responder is who we expected at stage 2. There is an open question on whether we keep the result of the work there (less disruptive in the event a lie disrupted a tunnel to a host you were communicating with) or discard the work. There is another PR nearly ready that speaks to this specific problem in a more elegant way.
Given the scope of the change, a few other items were included:
nil:4242
would be reported