Don't crash when gRPC metrics are enabled without a server #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
jscheinblum
approved these changes
Apr 12, 2024
dedelala
pushed a commit
that referenced
this pull request
May 30, 2024
* Make -grpc_prometheus work when not using a grpc server Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Make -grpc_prometheus work when not using a grpc server Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Make -grpc_prometheus work when not using a grpc server Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Make -grpc_prometheus work when not using a grpc server Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--grpc_prometheusenables server and client gRPC metrics. But if we don't have a gRPC server, but callservenv.Run()like we're doing here, the process will crash because of some uninitialized server state. Fix by moving the prom enable logic after the check to see if we actually have a server.This is still a bug upstream, so I'll send the fix there as well.