Vtgateproxy E2E tests #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlaine
force-pushed
the
vtgateproxy-e2e-test
branch
from
1e60723
to
32faf12
Compare
Signed-off-by: Riley Laine <rlaine@slack-corp.com>
Signed-off-by: Riley Laine <rlaine@slack-corp.com>
Signed-off-by: Riley Laine <rlaine@slack-corp.com>
Signed-off-by: Riley Laine <rlaine@slack-corp.com>
Signed-off-by: Riley Laine <rlaine@slack-corp.com>
rjlaine
force-pushed
the
vtgateproxy-e2e-test
branch
from
32faf12
to
0ea874f
Compare
rjlaine
commented
May 23, 2024
| @@ -317,7 +330,7 @@ func (b *JSONGateResolverBuilder) GetPools() []string { | |||
| return pools | |||
| } | |||
|
|
|||
| func (b *JSONGateResolverBuilder) GetTargets(poolType string) []targetHost { | |||
| func (b *JSONGateResolverBuilder) getTargets(poolType string) []targetHost { | |||
There was a problem hiding this comment.
Made private because its return type is private
henryr
approved these changes
May 31, 2024
dedelala
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Add end to end tests for vtgateproxy * Fix linter warnings and unhandled errors --------- Signed-off-by: Riley Laine <rlaine@slack-corp.com> Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Add end to end tests for vtgateproxy * Fix linter warnings and unhandled errors --------- Signed-off-by: Riley Laine <rlaine@slack-corp.com> Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Add end to end tests for vtgateproxy * Fix linter warnings and unhandled errors --------- Signed-off-by: Riley Laine <rlaine@slack-corp.com> Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add end to end tests for vtgateproxy.
Scenarios Tested
Running tests
You can run the tests locally as follows:
. dev.envmake toolsmake buildgo test -v ./go/test/endtoend/vtgateproxytest/ -run=TestVtgateProxyVtgateFailureFirstReady --logtostderr=1Outstanding changes
When we're ready to run tests in CI/CD, we'll want to add their configuration to
./test/config.jsonOther changes
Several references to global variables were replaced with local type attributes to facilitate testing.
Cases where errors were silently swallowed and not returned were fixed, so that errors are returned or logged in all cases.
Linter errors were also addressed.
The go mysql driver was updated to a newer version which supports connection attributes for pool routing in the default mysql driver client.