slack-15.0: forward ports slack specific v14 PRS fix
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
changed the title
slack-15.0: forward ports slack specific v14 PRS fix
| // authority holding a shard lock (PRS on vtctld) | ||
| log.Infof("slack-debug: we are actively setting replication source, exiting") | ||
|
|
||
| return nil |
There was a problem hiding this comment.
@vmogilev return nil makes the client unaware the repairReplication never happened. Should we return an error to the RPC caller that explains what happened?
|
@vmogilev I attempted to add a unit test so the race detector would prove this to be true, but it's a complicated test to write, so I have deferred this |
|
Adding more reviewers as I've now changed code |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
This reverts commit a9598fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
forward ports slack specific v14 PRS fix: #177
Related Issue(s)
Checklist
Deployment Notes