Pr 10956 slack vitess r12.0.5 #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
… version change Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
|
Thanks for the contribution! Before we can merge this, we need @dbussink to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Signed-off-by: Stanislav Maksimov <smaksimov@slack-corp.com> Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Signed-off-by: Stanislav Maksimov <smaksimov@slack-corp.com> Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
maksimov
force-pushed
the
pr-10956-slack-vitess-r12.0.5
branch
from
ece4cdb
to
002abf5
Compare
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
Signed-off-by: Stanislav Maksimov <smaksimov@slack-corp.com> Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
maksimov
force-pushed
the
pr-10956-slack-vitess-r12.0.5
branch
from
7355cd4
to
db4048c
Compare
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
maksimov
force-pushed
the
pr-10956-slack-vitess-r12.0.5
branch
from
db4048c
to
4503298
Compare
Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com>
This reverts commit 3bb4204.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes