TST: Fix tests segfault #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no functional code changes in this PR.
This is a long overdue fix of a small but annoying bug in the test suite. By properly cleaning up our tests we ensure that the test suite does not crash when it succeeds. I believe this is ignoring the root cause of the bug (something else about the test suite), but the fix is quick and suits my needs.
I ran into this issue when running full-environment integration tests where I run each test suite from all SLAC-made libraries that I'm using in my conda environment. It's hard to automatically verify that the environment is working correctly if the automatic tests unceremoniously crash at the end, so I thought I'd fix the issue here and push out a bugfix release.