-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set/control number of points in scatter plot by a PV #836
Set/control number of points in scatter plot by a PV #836
Conversation
prjemian
commented
May 9, 2022
•
edited
Loading
edited
- Close Plots: number of points supplied by a PV #608
- Close scatterplot.py needs a unit test suite #842
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 59.94% 59.81% -0.13%
==========================================
Files 95 95
Lines 11406 11441 +35
==========================================
+ Hits 6837 6844 +7
- Misses 4569 4597 +28
Continue to review full report at Codecov.
|
Noting that no unit tests have been added for this PR. But there is no specific unit test file for |
Feature looks great! Gave it a spin with some test PVs and it works like I would expect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the additional tests as well, this looks great to me!
@jbellister-slac Thanks! |