Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set/control number of points in scatter plot by a PV #836

Merged

Conversation

prjemian
Copy link
Collaborator

@prjemian prjemian commented May 9, 2022

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #836 (74cd60d) into master (4f6810f) will decrease coverage by 0.12%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   59.94%   59.81%   -0.13%     
==========================================
  Files          95       95              
  Lines       11406    11441      +35     
==========================================
+ Hits         6837     6844       +7     
- Misses       4569     4597      +28     
Impacted Files Coverage Δ
pydm/widgets/scatterplot_curve_editor.py 36.36% <14.28%> (-4.46%) ⬇️
pydm/widgets/scatterplot.py 29.16% <31.42%> (+0.59%) ⬆️
pydm/widgets/symbol_editor.py 80.51% <0.00%> (-0.37%) ⬇️
pydm/widgets/rules_editor.py 96.08% <0.00%> (-0.31%) ⬇️
pydm/main_window.py 52.20% <0.00%> (-0.28%) ⬇️
pydm/widgets/timeplot.py 70.73% <0.00%> (ø)
pydm/data_plugins/calc_plugin.py 25.54% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810f...74cd60d. Read the comment docs.

@prjemian prjemian marked this pull request as ready for review May 10, 2022 17:38
@prjemian
Copy link
Collaborator Author

Noting that no unit tests have been added for this PR. But there is no specific unit test file for scatterplot.py, either.

@jbellister-slac
Copy link
Collaborator

Feature looks great! Gave it a spin with some test PVs and it works like I would expect.

Copy link
Collaborator

@jbellister-slac jbellister-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additional tests as well, this looks great to me!

@jbellister-slac jbellister-slac merged commit 549fee9 into slaclab:master May 11, 2022
@prjemian prjemian deleted the 608-PV-number-of-points-to-plot branch May 11, 2022 16:41
@prjemian
Copy link
Collaborator Author

@jbellister-slac Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scatterplot.py needs a unit test suite Plots: number of points supplied by a PV
4 participants