Skip to content

Releases: slaclab/rogue

Patch Release v6.4.2

16 Oct 16:25
Compare
Choose a tag to compare

Pull Requests Since v6.4.1

Enhancement

  1. #1024 - Improve variable update performance

Unlabeled

  1. #1026 - ESROGUE-682 - Make Block.set() with numpy array work with proper array strides

Pull Request Details

Improve variable update performance

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Fri Sep 27 13:01:50 2024 -0700
Pull: #1024 (50 additions, 19 deletions, 3 files changed)
Branch: slaclab/ESROGUE-683
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-683
Labels: enhancement

Notes:

This PR improves the variable update performance by making the following changes:

  • Do not always check for the existence of a thread specific UpdateTracker object in the tracking list. This check requires an expensive dictionary lookup which previously occurred within a lock context. Instead the access is called as if the entry exists and if this is a new thread the resulting exception is caught and the object is then created inside the necessary lock. This change occurs in both the entry into the updateGroup context and more importantly in the _queueUpdates call.

  • Take advantage of the fact that each UpdateTrack instance is per thread and remove any locking around the update of this object.

  • In the check() call in the UpdateTrack first check the context counter and update period. This check is not expensive as compared to checking the variable list length, which now only occurs when the count and period tests pass.

  • Change the variable listener processing to only occur when the update worker processes the list. In the previous version, every listener for a variable was added with each set or get call which was not necessary. In the new code the listeners are first added to the existing update list before the update calls are made.


ESROGUE-682 - Make Block.set() with numpy array work with proper array strides

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Wed Oct 16 09:11:46 2024 -0700
Pull: #1026 (70 additions, 16 deletions, 2 files changed)
Branch: slaclab/ESROGUE-682
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-682

Notes:

Description

Previously the Block.setUIntPy() and related methods assumes a contiguous array. This would break with calls such as

arr = np.array([0,1,2,3,4,5])
var.set(np.arr[::2])

All of the underlying set() methods have been updated to properly iterate the numpy array.


Patch Release v6.4.1

28 Aug 18:05
eb0d921
Compare
Choose a tag to compare

Pull Requests Since v6.4.0

Bug

  1. #1017 - Fix var bytes calculation to support list variables which span transaction size
  2. #1020 - Fix rogue template for project libraries
  3. #1021 - Fix RSSI sgement size calculation

Enhancement

  1. #1018 - Add ability to pull a list value out in a pydm widget

Unlabeled

  1. #1019 - Update petalinux.rst
  2. #1023 - Make Rogue DataReceiver status Variables read-only

Pull Request Details

Fix var bytes calculation to support list variables which span transaction size

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Wed Aug 28 10:28:30 2024 -0700
Pull: #1017 (5 additions, 5 deletions, 3 files changed)
Branch: slaclab/block_alignment
Labels: bug

Notes:

This fixes how varBytes is calculated for list varibles. This change is neccessary to support list variables where the first entry of a list is beyond the min transaction size.

This does require that all entries added to a listVariable (block of memory) use the same offset value and use the bitOffset to define the location of each value in the block of memory.


Add ability to pull a list value out in a pydm widget

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Wed Jul 31 12:25:07 2024 -0700
Pull: #1018 (30 additions, 22 deletions, 10 files changed)
Branch: slaclab/ESROGUE-680
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-680
Labels: enhancement

Notes:

This add the ability to display a single list value in a pydm widget. Example channel value to achieve this is:

rogue://0/root.AxiVersion.TestListA/disp/3

There the last value is the index value.

There is a performance hit with this as the value has to be retrieved again to pull out the sliced value from the server:

def _updateVariable(self,path,varValue):

    if self._index != -1:
        varValue = self._node.getVariableValue(read=False, index=self._index)

Update petalinux.rst

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Fri Aug 16 19:56:19 2024 -0700
Pull: #1019 (4 additions, 4 deletions, 1 files changed)
Branch: slaclab/ruck314-patch-1

Notes:

Description

  • Updating instructions for rogue v6.4.0

Fix rogue template for project libraries

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Fri Aug 16 20:03:30 2024 -0700
Pull: #1020 (4 additions, 6 deletions, 1 files changed)
Branch: slaclab/update_template
Labels: bug

Notes:

This fixes the generated rogue cmake package used by project libraries.


Fix RSSI sgement size calculation

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Fri Aug 16 20:20:18 2024 -0700
Pull: #1021 (3 additions, 3 deletions, 2 files changed)
Branch: slaclab/udp_segment_size
Labels: bug

Notes:

The current segment size calculation does not include enough space for the RSSI header. This resulted in dropped packets when running with a 1500 byte MTU.


Make Rogue DataReceiver status Variables read-only

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Wed Aug 28 10:55:46 2024 -0700
Pull: #1023 (5 additions, 1 deletions, 1 files changed)
Branch: slaclab/data-receiver-ro

Notes:

Description

FrameCount, ErrorCount, ByteCount and Updated are now read only. This prevents them from being written in the GUI and from being dumped when saving a YAML configuration.

The Data Variable has been added to the 'NoConfig' group to prevent it from being dumped when saving a YAML configuration.


Minor Release v6.4.0

23 Jul 04:33
50f80b4
Compare
Choose a tag to compare

Pull Requests Since v6.3.0

Bug

  1. #1016 - High byte fix

Unlabeled

  1. #1012 - Adding C++ linter to CI
  2. #1010 - updating docker and conda to source reusable YAML CI scripts
  3. #1014 - Fix minimum value for Int

Pull Request Details

updating docker and conda to source reusable YAML CI scripts

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Wed Jul 10 14:16:12 2024 -0700
Pull: #1010 (12 additions, 85 deletions, 1 files changed)
Branch: slaclab/reusable-CI-yaml

Notes:

Description

  • Makes maintaining all these repos easier if they use the common YAML CI scripts for repetitive tasks

Adding C++ linter to CI

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Wed Jul 10 14:14:44 2024 -0700
Pull: #1012 (1397 additions, 1549 deletions, 270 files changed)
Branch: slaclab/ESROGUE-554
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-554

Notes:

Description

  • Improves the code quality by running the linter automatically for every commit via Github action

Fix minimum value for Int

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Fri Jul 19 17:23:33 2024 -0700
Pull: #1014 (1 additions, 1 deletions, 1 files changed)
Branch: SEBv15/main

Notes:

Description

pyrogue's integer type had it's minimum value set to -(2**(width-1)-1). In two's complement it's actually -2**(width-1)


High byte fix

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Mon Jul 22 21:19:22 2024 -0700
Pull: #1016 (6 additions, 1 deletions, 1 files changed)
Branch: slaclab/high_byte_fix
Labels: bug

Notes:

Fixes the high order byte value when performing reads from a list variable with index=-1.


Minor Release v6.3.0

25 Jun 20:17
Compare
Choose a tag to compare

Pull Requests Since v6.2.0

Bug

  1. #1007 - Fix bugs which did not allow array variables to share memory
  2. #1009 - Hot Fix: CMake and add memory emulate debug
  3. #1004 - bug fix for pydm/init.py

Enhancement

  1. #1009 - Hot Fix: CMake and add memory emulate debug

Unlabeled

  1. #1003 - Exposing the DMA's GIT Version and API Version to pyrogue variables
  2. #1002 - Fix CMake policy warnings
  3. #1006 - Update migration guide
  4. #1001 - Update rogue_ci.yml
  5. #1008 - Post-build step to remove egg files

Pull Request Details

Update rogue_ci.yml

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Tue May 28 13:19:33 2024 -0700
Pull: #1001 (13 additions, 30 deletions, 1 files changed)
Branch: slaclab/ruck314-patch-1

Notes:

Description

  • Updating CI to use the common gen_release workflow

Fix CMake policy warnings

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Thu Jun 13 14:46:05 2024 -0700
Pull: #1002 (56 additions, 50 deletions, 3 files changed)
Branch: JJL772/apply-cmake-policies

Notes:

Fix CMake policy warnings and upgrade CMake minimum version.

Description

  • Fix CMake policy CMP0148 by upgrading to FindPython3 from the old find package methods for Python
  • Fix CMake policy CMP0074 by correcting the case of the Boost_ROOT variable. Ironically they re-added the all-caps functionality in CMake 3.27.
  • Increased minimum CMake version to 3.15

Exposing the DMA's GIT Version and API Version to pyrogue variables

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Fri Jun 21 10:14:55 2024 -0700
Pull: #1003 (234 additions, 17 deletions, 5 files changed)
Branch: slaclab/ESROGUE-608
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-608

Notes:

Description


bug fix for pydm/init.py

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Tue May 28 13:08:27 2024 -0700
Pull: #1004 (19 additions, 1 deletions, 1 files changed)
Branch: slaclab/ESROGUE-600
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-600
Labels: bug

Notes:

Description

  • Fixed the bug where CTRL+C and SIGTERM were not calling the root.stop() function while closing the GUI

Update migration guide

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Wed Jun 12 11:10:27 2024 -0700
Pull: #1006 (67 additions, 8 deletions, 1 files changed)
Branch: slaclab/updateMigrationGuide

Notes:

Description

Add _rawWrite and _rawRead examples in migration to v.6 guide.


Fix bugs which did not allow array variables to share memory

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Fri Jun 21 09:57:29 2024 -0700
Pull: #1007 (304 additions, 198 deletions, 7 files changed)
Branch: slaclab/list_overlap
Labels: bug

Notes:

Existing code had a bug where you could not create list variables which shared memory space. For example a list of 32 - 16 bit values in the lower 16-bits of each 32-bit memory location, co-located with a list of 32 - 16 bit values in the upper 16-bit of each 32-bit memory location.

This PR fixes this error and also cleans up some of the code related to mapping bytes.


Post-build step to remove egg files

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Fri Jun 21 10:32:14 2024 -0700
Pull: #1008 (7 additions, 0 deletions, 1 files changed)
Branch: slaclab/ESROGUE-643
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-643

Notes:

Description

  • Egg files from PIP install can mess up python environments.
  • Make clean should remove the egg files.

Hot Fix: CMake and add memory emulate debug

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Tue Jun 25 12:38:43 2024 -0700
Pull: #1009 (21 additions, 7 deletions, 3 files changed)
Branch: slaclab/cmake_fix
Labels: bug, enhancement

Notes:

The existing Cmake script was broken in an anaconda environment.

This also adds additional debug for the memory emulator.


Minor Release v6.2.0

29 Apr 19:05
f9677e0
Compare
Choose a tag to compare

Pull Requests Since v6.1.4

Unlabeled

  1. #1000 - Re-run clang-format on C++ code
  2. #999 - AxiStreamDma: exposing all the TX/RX diagnostic ioctl() to python
  3. #995 - Document removal of legacy GUI
  4. #998 - Update petalinux.rst
  5. #997 - updating typeStr for Fixed/UFixed to match AMD naming convention

Pull Request Details

Re-run clang-format on C++ code

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Mon Apr 29 11:57:07 2024 -0700
Pull: #1000 (537 additions, 523 deletions, 78 files changed)
Branch: slaclab/lint6

Notes:

Description

Add clang-format option to indent pre-processor directives. This style seems much clearer.

Also, this is the 1000th PRs This is a huge milestone. Thank you to everyone who has contributed.

Details

After updating .clang-format, the following commands were run

> find . -type f -name "*.cpp" -print0 | xargs -0 sed -i -E 's/<(rogue\/.*)>/\"\1\"/'
> find . -type f -name "*.h" -print0 | xargs -0 sed -i -E 's/<(rogue\/.*)>/\"\1\"/'
> clang-format -i **/*.cpp **/*.h

Document removal of legacy GUI

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Wed Mar 27 09:34:40 2024 -0700
Pull: #995 (27 additions, 0 deletions, 1 files changed)
Branch: slaclab/gui-doc
Issues: #995

Notes:

Description

The Rogue documentation has been updated to note that the legacy GUI was removed in Rogue 6. Examples have been provided for how to migrate to the new PyDM GUI.


updating typeStr for Fixed/UFixed to match AMD naming convention

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Mon Apr 29 23:45:41 2024 +0700
Pull: #997 (2 additions, 2 deletions, 1 files changed)
Branch: slaclab/ESROGUE-649
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-649

Notes:

Description

  • This changes the 1st number in the fixed/ufixed typeStr from {self.bitSize} instead {self.bitSize-self.binPoint-1} to match the AMD naming convention

image


Update petalinux.rst

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Mon Apr 29 23:45:23 2024 +0700
Pull: #998 (10 additions, 5 deletions, 1 files changed)
Branch: slaclab/ESROGUE-651
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-651

Notes:

Description

  • migrating from distutils3(depreciated) to setuptools3

AxiStreamDma: exposing all the TX/RX diagnostic ioctl() to python

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Mon Apr 29 23:45:10 2024 +0700
Pull: #999 (312 additions, 0 deletions, 5 files changed)
Branch: slaclab/ESROGUE-592
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-592

Notes:

Description

Also added AxiStreamDmaMon python class for creating the LocalVariables

self.dmaStream = rogue.hardware.axi.AxiStreamDma(args.dev,(0x100*0)+0,1)                
self.add(pyrogue.hardware.axi.AxiStreamDmaMon(
    axiStreamDma = self.dmaStream,
    expand       = True,
))

Patch Release v6.1.4

27 Mar 05:03
de67a57
Compare
Choose a tag to compare

Pull Requests Since v6.1.3

Bug

  1. #994 - Update variable wait to allow for triggering on any update
  2. #992 - Fix doc gen typo

Enhancement

  1. #994 - Update variable wait to allow for triggering on any update
  2. #993 - Handle commands without arg in process widget

Unlabeled

  1. #989 - re-synchronizing with external aes-stream-drivers source code
  2. #988 - Initial capture of the pyrogue tree documentation
  3. #990 - Misc. Documentation Updates
  4. #987 - Fix bug in ArrayDevice

Pull Request Details

Fix bug in ArrayDevice

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Tue Mar 5 13:27:34 2024 -0800
Pull: #987 (1 additions, 1 deletions, 1 files changed)
Branch: slaclab/ArrayDevice-fix

Notes:

Description

When passing a single arrayArgs dict to ArrayDevice, need to copy the dict for each instantiated array member. Otherwise it is passed by reference and a later per-instance pop() call affects all instances.


Initial capture of the pyrogue tree documentation

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Tue Mar 5 13:25:18 2024 -0800
Pull: #988 (424 additions, 0 deletions, 12 files changed)
Branch: slaclab/device-tree-doc

Notes:

Initial capture of placeholder pages for documenting the pyrogue tree classes.

Description

Added documentation directories and index.rst files to capture the essential pyrogue tree classes: node, root, command, device and variable. Note that these are placeholder pages and not populated pages.

Details

Added the following directories and files:

docs/src/pyrogue_tree/index.rst
docs/src/pyrogue_tree/node/command/index.rst
docs/src/pyrogue_tree/node/command/local_command/index.rst
docs/src/pyrogue_tree/node/command/remote_command/index.rst
docs/src/pyrogue_tree/node/device/index.rst
docs/src/pyrogue_tree/node/index.rst
docs/src/pyrogue_tree/node/root/index.rst
docs/src/pyrogue_tree/node/variable/index.rst
docs/src/pyrogue_tree/node/variable/link_variable/index.rst
docs/src/pyrogue_tree/node/variable/local_variable/index.rst
docs/src/pyrogue_tree/node/variable/remote_variable/index.rst
docs/src/index.rst

Removed the following file:
docs/src/pyrogue_tree/_Node.py

JIRA

N/A

Related

N/A


re-synchronizing with external aes-stream-drivers source code

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Tue Mar 5 13:28:54 2024 -0800
Pull: #989 (698 additions, 698 deletions, 3 files changed)
Branch: slaclab/include-driver-syncing-up
Issues: #914, #989

Notes:

Description


Misc. Documentation Updates

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Tue Feb 27 11:51:14 2024 -0800
Pull: #990 (20 additions, 19 deletions, 3 files changed)
Branch: slaclab/more-tcp-doc-updates
Issues: #990

Notes:

Description


Fix doc gen typo

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Thu Mar 7 15:04:56 2024 -0800
Pull: #992 (1 additions, 1 deletions, 1 files changed)
Branch: slaclab/doc_gen
Issues: #992
Labels: bug

Notes:

Fixes a typo that was breaking document generation.

This also updates the Process pydm window to generate a "Exec" button instead of an input field when a command does not take a arg.


Handle commands without arg in process widget

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Tue Mar 26 13:12:35 2024 -0700
Pull: #993 (5 additions, 0 deletions, 1 files changed)
Branch: slaclab/fix_process_widget
Labels: enhancement

Notes:

Handle commands without arg in process widget.

This ensures a button is present for process commands that do not take an arg.


Update variable wait to allow for triggering on any update

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Tue Mar 26 13:09:08 2024 -0700
Pull: #994 (17 additions, 18 deletions, 3 files changed)
Branch: slaclab/variable_wait
Issues: #994
Labels: bug, enhancement

Notes:

This adds an update flag to the local VariableValue class used in the variable wait lambda function. This allows VariableWait to stall on an update of a variable without caring about a particular value. This is useful for variables which are updated on data reception.

This also updates the incorrect documentation and code comments.

The Advance function is removed from the Process class and the default example loop updates are fixed.


Patch Release v6.1.3

08 Feb 22:15
04d1e8a
Compare
Choose a tag to compare

Pull Requests Since v6.1.2

Bug

  1. #986 - Release Candidate v6.1.3

Pull Request Details

Release Candidate v6.1.3

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Thu Feb 8 14:09:08 2024 -0800
Pull: #986 (1 additions, 1 deletions, 1 files changed)
Branch: slaclab/docker_typo_patch
Labels: bug

Notes:

Description

  • Fix typo in file path to Docker context.
    • Patches the file path to the Docker context.

Patch Release v6.1.2

08 Feb 20:51
0a7d4dd
Compare
Choose a tag to compare

Pull Requests Since v6.1.1

Bug

  1. #984 - Fix bug in Device.setPollInterval()
  2. #985 - Fix suggested default address. Fix broken address/port lookup
  3. #983 - Fix nodeList method in Node and add global node count tracking

Enhancement

  1. #977 - Use NTScalarArray for 1D arrays.
  2. #976 - Docker context that uses Anaconda to build rogue
  3. #985 - Fix suggested default address. Fix broken address/port lookup
  4. #983 - Fix nodeList method in Node and add global node count tracking

Documentation

  1. #984 - Fix bug in Device.setPollInterval()

Unlabeled

  1. #979 - test_block_overlap.py update
  2. #980 - Update LICENSE.txt

Pull Request Details

Docker context that uses Anaconda to build rogue

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Mon Jan 8 11:20:05 2024 -0800
Pull: #976 (22 additions, 3 deletions, 3 files changed)
Branch: slaclab/docker-dev
Issues: #976
Labels: enhancement

Notes:

Description

This PR adds a Docker context that builds rogue using Anaconda and automatically runs the virtual rogue environment at start up. The context that builds rogue bare-metal has been renamed to rogue to distinguish it from the Anaconda version.

Details

The Anaconda Docker context uses continuumio/anaconda3 as the base image and creates an environment using the latest rogue tag. To test if the rogue conda environment was automatically started, I used the following command

docker run -it <image_name>

The git workflow was updated so it can find the correct location of the original bare-metal context. For now, the Anaconda context is not automatically built and deployed to DockerHub.


Use NTScalarArray for 1D arrays.

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Tue Oct 31 13:58:30 2023 -0700
Pull: #977 (112 additions, 77 deletions, 1 files changed)
Branch: slaclab/array-dev
Issues: #6, #977
Labels: enhancement

Notes:

This PR updates the protocol epicsV4 to use the normative type NTScalar when a 1D array is encountered. Currently, the type NTNDArray is being used but that is meant to encode a data frame from a detector or an image from a camera.

Description

Make use of the normative type NTScalar when encoding 1D arrays in pyrogue.protocols.epicsV4.

JIRA

https://jira.slac.stanford.edu/browse/ESROGUE-640

Related

This PR addresses the following issue: slaclab/darpa-accel-llrf-phase-1p5#6


test_block_overlap.py update

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Thu Jan 11 13:34:14 2024 -0800
Pull: #979 (29 additions, 5 deletions, 4 files changed)
Branch: slaclab/var-overlaps-corner-case
Issues: #979

Notes:

Description

  • Adding corner case to test_block_overlap.py for non-4kB aligned base offset
  • Fix bug found when running test_block_overlap.py

Overlap bug fix

Rogue was implicitly requiring that Device offsets fall on orthogonal "power-of-two" boundaries, e.g. 0x123000, 0xF00, where the LSB zeros indicate the address space of the Device. For most firmware with registers on an AXI-Lite bus, this will always be the case. But a corner case was recently encountered where an I2C peripheral requires a very odd offset. This change will support such offsets without breaking existing functionality.


Update LICENSE.txt

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Tue Dec 19 09:55:40 2023 -0800
Pull: #980 (1 additions, 1 deletions, 1 files changed)
Branch: slaclab/ruck314-patch-1

Notes:

Description

  • Updating for Year 2024

Fix nodeList method in Node and add global node count tracking

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Thu Jan 11 13:07:10 2024 -0800
Pull: #983 (7 additions, 1 deletions, 1 files changed)
Branch: slaclab/node_count
Labels: bug, enhancement

Notes:

Description

Fixes the Node method nodeList which was broken.

Also adds a class counter for Node to determine how many nodes exist in the system as a scaling metric.


Fix bug in Device.setPollInterval()

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Tue Jan 23 13:12:07 2024 -0800
Pull: #984 (50 additions, 30 deletions, 2 files changed)
Branch: slaclab/poll_interval_fix
Issues: #983, #984
Labels: bug, documentation

Notes:

Description

This fixes a bug where Device.setPollInterval() was making an obsolete call to set the poll interval of each variable.

Documentation has also been updated to make note of the API change when setting Variable poll interval in Rogue v6.

Related

Need to merge #983 first.


Fix suggested default address. Fix broken address/port lookup

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Wed Feb 7 11:46:12 2024 -0800
Pull: #985 (7 additions, 3 deletions, 3 files changed)
Branch: slaclab/server_addr
Issues: #985
Labels: bug, enhancement

Notes:

This updates the documentation to suggest using 127.0.0.1 for the zmqServer listen address. This will avoid getting annoying messages from cyber security port scanners.

We still need to properly document ZmqServer to explain the various addr arg options.

I also fixed a bug where the address lookup always returns localhost, which will break the gui when users define options other than * or 127.0.0.1


Patch Release v6.1.1

21 Sep 00:51
64ac9ce
Compare
Choose a tag to compare

Pull Requests Since v6.1.0

Bug

  1. #973 - Add warning when loading a configuration and variable mode is not enabled

Enhancement

  1. #972 - Add threshold to rate test
  2. #974 - Update workflow to avoid deprecated set-output command
  3. #973 - Add warning when loading a configuration and variable mode is not enabled

Unlabeled

  1. #971 - Fix LocalVariable numpy array compare

Pull Request Details

Fix LocalVariable numpy array compare

Author: Benjamin Reese bengineerd@users.noreply.github.com
Date: Tue Sep 19 13:05:27 2023 -0700
Pull: #971 (82 additions, 60 deletions, 5 files changed)
Branch: slaclab/ben-bug-fixes
Issues: #971

Notes:

Description

Fix the compare of numpy arrays when LocalVariable.set() is called.

Also fix a bug in the Packetizer debug logging where SOF was being reported with a 7-bit shift.

Finally, fix some code formatting for readability.

Details

At some point, numpy changed the != operator to be an element-wise compare rather an an array compare. This change makes the correct numpy API calls to compare the new array against the old.


Add threshold to rate test

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Wed Sep 20 17:25:06 2023 -0700
Pull: #972 (43 additions, 14 deletions, 2 files changed)
Branch: slaclab/ESROGUE-538
Issues: #972
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-538
Labels: enhancement

Notes:

This PR applies a threshold to the test_rate python script. This can be used to determine if changes have significant impact on the variable access rates.


Add warning when loading a configuration and variable mode is not enabled

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Wed Sep 20 17:25:32 2023 -0700
Pull: #973 (5 additions, 0 deletions, 2 files changed)
Branch: slaclab/ESROGUE-641
Issues: #973
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-641
Labels: bug, enhancement

Notes:

By default loading a configuration does not apply to WO variables. Instead of failing silently this PR will generate a warning message when an entry exists in the configuration file, but will not be used because the variable has a mode which is not enabled for the configuration load.

This also fixes a bug found in the display value for the DataReceiver.


Update workflow to avoid deprecated set-output command

Author: Ryan Herbst rherbst@slac.stanford.edu
Date: Wed Sep 20 12:41:32 2023 -0700
Pull: #974 (4 additions, 5 deletions, 1 files changed)
Branch: slaclab/ESROGUE-638
Issues: #974
Jira: https://jira.slac.stanford.edu/issues/ESROGUE-638
Labels: enhancement

Notes:

This replaces the set-output command with the recommend fix from github. We will not know if this works until the next release generation.


Patch Release v4.11.11

04 Sep 04:11
9b6a976
Compare
Choose a tag to compare

Pull Requests Since v4.11.10

Enhancement

  1. #970 - Update aes-stream-driver to latest version

Pull Request Details

Update aes-stream-driver to latest version

Author: Larry Ruckman ruckman@slac.stanford.edu
Date: Sun Sep 3 08:18:42 2023 -0700
Pull: #970 (470 additions, 602 deletions, 5 files changed)
Branch: slaclab/v4.11.11_rel
Labels: enhancement

Notes:

PR for Rogue version 4.

Update aes-stream-drivers to latest version.