Formula Viewer for Archive Viewer #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# The first commit's message is: ENH: Building on the Archive Viewer to include formulas of PVs (or other formulas) # This is the 2nd commit message: Have it graphing A over itself # This is the 3rd commit message: Fixed issue with default colors # This is the 4th commit message: Done with functions # This is the 5th commit message: Traces table now populates dialogue with previous formula, curve model handles switching from archive plots to formulas and formulas to formulas, TODO handling formula to archive plots # This is the 6th commit message: Formula -> archive and fixing archive -> formula # This is the 7th commit message: temp # This is the 8th commit message: Clicking enter to accept formula works # This is the 9th commit message: Comments
zdomke
reviewed
Jul 23, 2024
zdomke
requested changes
Jul 25, 2024
zdomke
reviewed
Jul 30, 2024
zdomke
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Looks really good. I had a couple of things I noticed in your new code. A couple of things for you to make sure you do before PR:
- Clear out all of your extra print statements
- Make sure your comments are easy to read:
a. Space separating the '#' and the comment ("#Comment" --> "# Comment")
b. Capitalize the first character in the comment ("# comment" --> "# Comment")
|
@aksharsarvesh This PR is just an outdated duplicate of #31 right? Can we close this PR or should it stay open? |
|
Yes this is trash. Just here because I wanted to document previous comments |
|
Closing PR. It can still be found in the list of closed PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to traces_table and curves_model to allow for formulas to be graphed. Traces table helps handle formula input, and curves model handles not only Archive Plot curves but also new formulas. Formulas can be functions of PVs or of other functions.