-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken for Clojure 1.3.0 projects #13
Comments
Matthew, Thanks for the report. Indeed these vars need the :dynamic entry in their metadata for 1.3. However, I'm having a problem getting every thing working on 1.3. I'm led to believe that there may be a bug in the new Clojure implementation. Investigation is underway. Assuming we can get everything working, I'll push a new release of Speclj that's compatible with 1.3. Micah On Oct 15, 2011, at 6:44 PM, Matthew Boston wrote:
|
Thank you, Micah. I'm taking a look at it as well. Hopefully we can find a solution. |
Has there been any update on this? Anything I can do to help? I was considering switching a few of my projects to speclj and 1.3 compatibility is a prerequisite now that it's been released. |
Lee, There was a thread on this topic on IRC, then it went on the email list, and finally I presonally reached out to Rich among other people. In the end, Rich added a 2 line fix to Clojure 1.4, and magically Speclj works. 1.4 will be released at ClojureConj in a couple weeks as I understand. I could be wrong but It seem like 1.3 will not see another release… so Speclj will likely never work on 1.3. Micah On Nov 3, 2011, at 12:55 PM, Lee wrote:
|
That's too bad, well I'll look forward to one that works with clojure 1.4 here in a fews weeks, thanks for the quick reply :) |
Will be fixed with the release of Clojure 1.4 |
Thanks for this thread, because it answered a question I had after putting in the dynamic meta data. I'll stay on 1.2 until 1.4. |
Sure thing. Hopefully 1.4 comes out soon. tap tap tap |
Hmm, I tried it on the latest alpha ( |
@gf3 did you build speclj with clojure 1.4.x as a dependency? |
I was waiting for Clojure 1.4 to come out of beta before releasing the fix, but actually there's not need to wait since the changes are backwards compatible. Speclj 2.0.0 has just been released. It works with Clojure 1.4.0-alpha3, but it won't work with Clojure 1.3. Micah On Dec 27, 2011, at 2:34 PM, Gianni Chiappetta wrote:
|
Amazing, thank-you @slagyr! |
@slagyr could you upload 2.0.0 to clojars? Thanks! |
Doh! Done. Micah On Dec 29, 2011, at 3:00 AM, Matthew Boston wrote:
|
This is due to Clojure 1.3.0 Release Feature 1.1: Earmuffed Vars Are No Longer Automatically Considered Dynamic.
https://github.com/clojure/clojure/blob/master/changes.md
I get the following stacktrace when running
lein spec
for Clojure 1.3.0:The text was updated successfully, but these errors were encountered: