Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app.rs: fix (add) version output (fixes #32) #33

Merged
merged 1 commit into from
Aug 6, 2020
Merged

app.rs: fix (add) version output (fixes #32) #33

merged 1 commit into from
Aug 6, 2020

Conversation

andy5995
Copy link
Contributor

@andy5995 andy5995 commented Aug 6, 2020

No description provided.

slai11
slai11 approved these changes Aug 6, 2020
View reviewed changes
Copy link
Owner

@slai11 slai11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for submitting the PR and issues! Before merging, could I trouble you to set the commit message to start with fix(add): version output?

@slai11 slai11 merged commit 8320738 into slai11:master Aug 6, 2020
@andy5995
Copy link
Contributor Author

andy5995 commented Aug 6, 2020

lgtm. Thank you for submitting the PR and issues! Before merging, could I trouble you to set the commit message to start with fix(add): version output?

You're welcome @slai11 ... and now I see you're using the Conventional Commits style. I'll remember that next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slai11 slai11 slai11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy5995 @slai11