This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
+sanity #17 add sanity scripts (formatting, license) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple formatting hook, similar to the one used in NIO and other projects.
I didn't add license validation yet. We'd eventually want the same "header" as we do in NIO and others: https://github.com/apple/swift-nio/blob/master/Tests/NIOTestUtilsTests/ByteToMessageDecoderVerifierTest%2BXCTest.swift#L1-L13 but didn't add it yet.
The settings inspired by NIO and some other projects where we use swiftformat, hope they're fine @slashmo
// we're sticking to
SwiftFormat, version 0.44.6in our builds nowadays AFAICS (docker images etc), so that's what this was formatted with.