Centralize Paths (Possibly fixes #43) #44
Conversation
| @@ -16,7 +16,7 @@ def __init__(self): | |||
| if is_compiled(): | |||
| self.cache_folder_path = "../../storage/cache/message-ids" | |||
| else: | |||
| self.cache_folder_path = "../../release/dcef/storage/cache/message-ids" | |||
| self.cache_folder_path = "../../cache/message-ids" | |||
There was a problem hiding this comment.
This change will break development environment. I will restructure the project folder structure to fix paths later
There was a problem hiding this comment.
Is there anything I can do to resolve this to make it easier on you? I am on my way to bed now as its 11PM here, but after I get back from school tomorrow I can make the changes. Where would I look to find the breakage?
|
Hello, you don't need dockerhub to build the docker image. Just follow instructions in README.md#other-ways-to-run-dcef and build docker image from source. - TL;DR Also it is expected that you would add your own reverse proxy (for example nginx) to handle logging, SSL certificates, rate limiting,... . That's why nginx logs were not made to be persistent in Sorry, I won't merge this pull request as is, project needs bigger folder restructure to fix this issue (moving |
Hello!
I didn't want to just complain so I went through and made some quick changes to the paths. I don't have a dockerhub account and I'm not really sure how to build docker images in the first place so I can't test it, but they're relatively simple changes.
Hope this helps! Thanks for the awesome software!