#469: Update grammar to support Swift 3.0.1 #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add grammar for tuple expressions - Add playground literal grammar - Remove expressionElementList and use tupleElementList instead - Add function call grammar - Modify postfixExpression grammar - Fix every test that broke because of these changes ...
a4sriniv
force-pushed
the
as-469-swift-3_0_1
branch
from
1fdea21
to
7deaccb
Compare
adityatrivedi
approved these changes
Mar 6, 2017
| @@ -771,11 +798,7 @@ postfixOperator : operator ; | |||
| sType | |||
There was a problem hiding this comment.
Is this named sType instead of Type for name clash?
|
Great work! 🎉 Don't forget to update the wiki 😃 ! Can you also update the |
| @@ -99,7 +99,7 @@ defaultLabel : 'default' ':' ; | |||
|
|
|||
| // GRAMMAR OF A LABELED STATEMENT | |||
|
|
|||
| labeledStatement : statementLabel loopStatement | statementLabel switchStatement ; | |||
| labeledStatement : statementLabel (loopStatement | ifStatement | switchStatement | doStatement) ; | |||
There was a problem hiding this comment.
Would it be possible to add grammar tests for this change?
| unionStyleEnumMembers : unionStyleEnumMember+ ; | ||
| unionStyleEnumMember : declaration | unionStyleEnumCaseClause ';'? ; | ||
| unionStyleEnumMember : declaration | unionStyleEnumCaseClause ';'? | compilerControlStatement ; |
There was a problem hiding this comment.
Would it be possible to add grammar tests for these changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #469.