Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve class structure sniff #895

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Improve class structure sniff #895

merged 2 commits into from
Feb 5, 2020

Conversation

grongor
Copy link
Contributor

@grongor grongor commented Feb 5, 2020

Example of new error message:
The placement of "protected static abstract methods" group is invalid. Last group was "public methods" and one of these is expected after it: public methods, public static methods, protected methods, protected static methods, private methods, private static methods, magic methods

@grongor
Copy link
Contributor Author

grongor commented Feb 5, 2020

... lol, error in your cs config :D It's already proving useful :)

@grongor grongor requested a review from kukulich February 5, 2020 14:57
Copy link
Contributor

@kukulich kukulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit "Improve violation message for ClassStructureSniff" are changes that belong to the other commit.

@grongor
Copy link
Contributor Author

grongor commented Feb 5, 2020

Yeah sorry, rebase error ... fixed

@kukulich kukulich merged commit 3f28b83 into slevomat:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants