Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thinwall improvements #4472

Merged
merged 5 commits into from
Jul 5, 2018
Merged

Conversation

supermerill
Copy link
Collaborator

  • no more strange turn at end => fusion of voronoi end lines when they are near enough
  • anchoring inside the perimeters => extends the lines end inside the perimeter to join it. A gui parameter can be created to adjust it if needed (currently, it extends to meet the center).
  • conservation of too small segments of thin walls when they are crossing each other => modification of the fusion algorithm to select the most strait path instead of a random one

supermerill and others added 5 commits July 5, 2018 11:32
Converting comments to C++ style, fixed typos in comments.
C-style comments are normally reserved for commenting out code blocks, not descriptions.
@lordofhyphens lordofhyphens added this to the 1.3.1 milestone Jul 5, 2018
@lordofhyphens lordofhyphens merged commit cc42bb4 into slic3r:master Jul 5, 2018
@lordofhyphens
Copy link
Member

Merging, will keep an eye as to whether or not this causes other problems.

@supermerill
Copy link
Collaborator Author

Just a note: the changes are in a function which is also used by gaps.
If gaps behaving weirdly, it may be useful to split the function for the 2 needs (thinwalls vs gaps).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants