Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: tab controls not labeled properly
The tab controls should be announced with the correct tab role, number and position as e.g., 'Smileys and People, selected, tab, 1 of 8'. Adding tablist role for the parent and tab role for the button does the trick. I also modified aria-selected prop. Why? Using aria-selected={selected || undefined} can be problematic because it leads to inconsistent behaviour with how assistive technologies interpret the presence and value of the aria-selected attribute. The aria-selected attribute is meant to have a clear true or false value to indicate the selected state.
- Loading branch information