fix(emoji-picker): add no result to aria region #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanPodmajersky
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Hey @torgeadelin, thank you for the contribution.
Could you please also add an explanation (copy the text from pr description) to commit's body. As PR is just temporary but commits stays forever ;). (You can check other commits in this fork, eg: 6417fbb) Thank you.
- adds no result message to aria live region BUG: Emoji - Search - No emoji found is not announced: SPARK-522103 Expected Result: No emoji found in the search results should be announced to the screen reader users, e.g. No Emoji Found Actual Result: When the user types in the search, the No emoji found displayed in the search results is not announced to the screen reader users. HTML: `<div class=emoji-mart-no-results><span aria-label=, sleuth_or_spy title=sleuth_or_spy class=emoji-mart-emoji emoji-mart-emoji-native>….</div>` Solution: Use aria-live to announce the information about No Emoji Found in the search result
|
@JanPodmajersky done! :) |
daelmaak
reviewed
Aug 5, 2024
…ition Co-authored-by: Daniel Macák <34311965+daelmaak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to
BUG: Emoji - Search - No emoji found is not announced: SPARK-522103
Expected Result: No emoji found in the search results should be announced to the screen reader users,
e.g. No Emoji Found
Actual Result: When the user types in the search, the No emoji found displayed in the search results is not announced to the screen reader users.
HTML:
<div class=emoji-mart-no-results><span aria-label=, sleuth_or_spy title=sleuth_or_spy class=emoji-mart-emoji emoji-mart-emoji-native>….</div>Solution: Use aria-live to announce the information about No Emoji Found in the search result