Feature/mail #27
Merged
Feature/mail #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
There was a problem hiding this comment.
There is some code formatting issues. Remove unnecessary line gaps and try Prettier
Comment on lines
+1
to
+10
| const CREDENTIALS = { | ||
| HOST: "smtp.mailtrap.io", | ||
| PORT: "2525", | ||
| USER: "c8cca3941aea9c", | ||
| PASSWORD: "18763bafd470a9", | ||
| }; | ||
|
|
||
| export default { | ||
| CREDENTIALS, | ||
| }; |
There was a problem hiding this comment.
Don't push secrets to a public repository. Gitignore it. when we're deploying the app we can put this as a config file. But still wondering how we configure this for github actions 🤨. Need to find a way
chamodshehanka
requested changes
Mar 1, 2021
There was a problem hiding this comment.
PR is overall good. But need to find a way for config file.
@ebonynon @susithrupasinghe Let's discuss about that in discussion
chamodshehanka
approved these changes
Mar 1, 2021
|
Gonna merge this for now. Let's discuss the issue in here #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sending Mails to user/ set of users #6
Goals
Approach
Checklist