lazyload: remove ISTIO_META_ISTIO_VERSION from gs when accesslog is used #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
由于社区版本1.13以及之后会下发 stats-filter envoyfilter， 这影响了prometheus方式的lazyload获取指标
所以给global-sidecar加了
ISTIO_META_ISTIO_VERSION: 999.0.0, 表示不需要下发这些stats-filter至global-sidecar如果懒加载采用accesslog方式，就不必加上
ISTIO_META_ISTIO_VERSION: 999.0.0