Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline nesting #122

Merged
merged 2 commits into from
May 5, 2017
Merged

Fix inline nesting #122

merged 2 commits into from
May 5, 2017

Conversation

feymartynov
Copy link
Contributor

Currently this:

.row: .col-lg-12: p Hello World

gets compiled into:

<div class="row"><col-lg-12>p Hello World</col-lg-12></div>

With this PR it becomes:

<div class="row"><div class="col-lg-12"><p>Hello World</p></div></div>

@Rakoth
Copy link
Member

Rakoth commented Apr 22, 2017

Hi, @feymartynov, thanks for your PR! Could you please add an end-to-end rendering test case for this bug?

@feymartynov
Copy link
Contributor Author

Sure, will do it.

I also missed mixed nesting case which is more close to real life:

.wrap: .row: .col-lg-12
  .box: p One
  .box: p Two
p Three

=>

<div class="wrap">
  <div class="row">
    <div class="col-lg-12">
      <div class="box">
        <p>One</p>
      </div>
      <div class="box">
        <p>Two</p>
      </div>
    </div>
  </div>
</div>
<p>Three</p>

That's a bit more tricky but I'll try.

@feymartynov
Copy link
Contributor Author

@Rakoth check it out please.

Copy link
Member

@Rakoth Rakoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work, @feymartynov!

@Rakoth Rakoth merged commit 4ed7331 into slime-lang:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants