Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illumination and precon #151

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Illumination and precon #151

merged 6 commits into from
Nov 22, 2022

Conversation

mloubout
Copy link
Member

@mloubout mloubout commented Oct 27, 2022

Revives illumination operator, supersedes #90

Fixes #48

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 84.10% // Head: 82.36% // Decreases project coverage by -1.73% ⚠️

Coverage data is based on head (2744845) compared to base (fbb2168).
Patch coverage: 73.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   84.10%   82.36%   -1.74%     
==========================================
  Files          25       28       +3     
  Lines        2000     2143     +143     
==========================================
+ Hits         1682     1765      +83     
- Misses        318      378      +60     
Impacted Files Coverage Δ
src/rrules.jl 74.07% <0.00%> (-9.26%) ⬇️
...imeModeling/Preconditioners/DataPreconditioners.jl 60.36% <60.36%> (ø)
...meModeling/Preconditioners/ModelPreconditioners.jl 67.96% <67.96%> (ø)
src/TimeModeling/Types/ModelStructure.jl 86.53% <68.42%> (-0.31%) ⬇️
src/TimeModeling/Preconditioners/base.jl 72.72% <72.72%> (ø)
src/TimeModeling/Utils/auxiliaryFunctions.jl 78.93% <74.19%> (+0.27%) ⬆️
src/TimeModeling/Modeling/misfit_fg.jl 89.55% <75.00%> (-3.67%) ⬇️
src/TimeModeling/Preconditioners/utils.jl 90.90% <90.90%> (ø)
src/TimeModeling/Modeling/python_interface.jl 99.15% <97.82%> (-0.06%) ⬇️
src/JUDI.jl 88.88% <100.00%> (+0.65%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mloubout mloubout force-pushed the illum-again branch 15 times, most recently from 835a849 to 764dcec Compare November 3, 2022 19:20
@mloubout mloubout force-pushed the illum-again branch 5 times, most recently from 60a8e4c to 5a4c187 Compare November 4, 2022 02:24
@mloubout mloubout changed the title [WIP] illumination Illumination and precon Nov 4, 2022
@mloubout mloubout force-pushed the illum-again branch 6 times, most recently from 56cbf8f to 467c780 Compare November 22, 2022 14:52
@mloubout mloubout merged commit e89fb68 into master Nov 22, 2022
@mloubout mloubout deleted the illum-again branch November 22, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overload DepthScaling and Topmute operators for PhysicalParameter?
1 participant